[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4aef483f-df7f-420a-abba-b2fc27db0105@gmail.com>
Date: Mon, 24 Nov 2025 22:25:23 +0530
From: Bhanu Seshu Kumar Valluri <bhanuseshukumar@...il.com>
To: Vinod Koul <vkoul@...nel.org>, Jonathan Corbet <corbet@....net>
Cc: dmaengine@...r.kernel.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, khalid@...nel.org,
linux-kernel-mentees@...ts.linuxfoundation.org, skhan@...uxfoundation.org,
david.hunter.linux@...il.com
Subject: Re: [PATCH] docs: dmaengine: add explanation for phys field in
dma_async_tx_descriptor structure
On 13/11/25 12:19, Bhanu Seshu Kumar Valluri wrote:
> Describe the need to initialize the phys field in the dma_async_tx_descriptor
> structure during its initialization.
>
> Signed-off-by: Bhanu Seshu Kumar Valluri <bhanuseshukumar@...il.com>
> ---
> Documentation/driver-api/dmaengine/provider.rst | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/driver-api/dmaengine/provider.rst b/Documentation/driver-api/dmaengine/provider.rst
> index 1594598b3..f4ed98f70 100644
> --- a/Documentation/driver-api/dmaengine/provider.rst
> +++ b/Documentation/driver-api/dmaengine/provider.rst
> @@ -411,7 +411,7 @@ supported.
> - This structure can be initialized using the function
> ``dma_async_tx_descriptor_init``.
>
> - - You'll also need to set two fields in this structure:
> + - You'll also need to set following fields in this structure:
>
> - flags:
> TODO: Can it be modified by the driver itself, or
> @@ -421,6 +421,9 @@ supported.
> that is supposed to push the current transaction descriptor to a
> pending queue, waiting for issue_pending to be called.
>
> + - phys: Physical address of the descriptor which is used later by
> + the dma engine to read the descriptor and initiate transfer.
> +
> - In this structure the function pointer callback_result can be
> initialized in order for the submitter to be notified that a
> transaction has completed. In the earlier code the function pointer
Hi,
I just wanted to check if you had a chance to review it or if any changes are needed from my side.
Regards,
Bhanu Seshu Kumar Valluri
Powered by blists - more mailing lists