linux-kernel - Re: [PATCH net-next] ice: fix broken Rx on VFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7bd3f03-fa2f-495c-94cb-8e310608cee6@intel.com>
Date: Mon, 24 Nov 2025 18:17:56 +0100
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: Przemek Kitszel <przemyslaw.kitszel@...el.com>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, Jakub Slepecki <jakub.slepecki@...el.com>,
	<nxne.cnse.osdt.itp.upstreaming@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] ice: fix broken Rx on VFs

From: Alexander Lobakin <aleksander.lobakin@...el.com>
Date: Mon, 24 Nov 2025 18:07:35 +0100

Ooops, missed a tag, sorry...

> Since the tagged commit, ice stopped respecting Rx buffer length
> passed from VFs.
> At that point, the buffer length was hardcoded in ice, so VFs still
> worked up to some point (until, for example, a VF wanted an MTU
> larger than its PF).
> The next commit 93f53db9f9dc ("ice: switch to Page Pool"), broke
> Rx on VFs completely since ice started accounting per-queue buffer
> lengths again, but now VF queues always had their length zeroed, as
> ice was already ignoring what iavf was passing to it.
> 
> Restore the line that initializes the buffer length on VF queues
> basing on the virtchnl messages.
> 
> Fixes: 3a4f419f7509 ("ice: drop page splitting and recycling")
> Reported-by: Jakub Slepecki <jakub.slepecki@...el.com>

Suggested-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

> Reviewed-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> ---
> I'd like this to go directly to net-next to quickly unbreak VFs
> (the related commits are not in the mainline yet).
Thanks,
Olek