linux-kernel - RE: [Intel-wired-lan] [PATCH net-next] ice: fix broken Rx on VFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986B1C6A48D9050379B0B1FE5D1A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Tue, 25 Nov 2025 06:32:17 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Lobakin, Aleksander" <aleksander.lobakin@...el.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>
CC: "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Slepecki, Jakub" <jakub.slepecki@...el.com>,
	NXNE CNSE OSDT ITP Upstreaming <nxne.cnse.osdt.itp.upstreaming@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH net-next] ice: fix broken Rx on VFs



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Alexander Lobakin
> Sent: Monday, November 24, 2025 6:18 PM
> To: Andrew Lunn <andrew+netdev@...n.ch>; David S. Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub
> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>
> Cc: Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; Nguyen,
> Anthony L <anthony.l.nguyen@...el.com>; Slepecki, Jakub
> <jakub.slepecki@...el.com>; NXNE CNSE OSDT ITP Upstreaming
> <nxne.cnse.osdt.itp.upstreaming@...el.com>; intel-wired-
> lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [Intel-wired-lan] [PATCH net-next] ice: fix broken Rx on
> VFs
> 
> From: Alexander Lobakin <aleksander.lobakin@...el.com>
> Date: Mon, 24 Nov 2025 18:07:35 +0100
> 
> Ooops, missed a tag, sorry...
> 
> > Since the tagged commit, ice stopped respecting Rx buffer length
> > passed from VFs.
> > At that point, the buffer length was hardcoded in ice, so VFs still
> > worked up to some point (until, for example, a VF wanted an MTU
> larger
> > than its PF).
> > The next commit 93f53db9f9dc ("ice: switch to Page Pool"), broke Rx
> on
> > VFs completely since ice started accounting per-queue buffer lengths
> > again, but now VF queues always had their length zeroed, as ice was
> > already ignoring what iavf was passing to it.
> >
> > Restore the line that initializes the buffer length on VF queues
> > basing on the virtchnl messages.
> >
> > Fixes: 3a4f419f7509 ("ice: drop page splitting and recycling")
> > Reported-by: Jakub Slepecki <jakub.slepecki@...el.com>
> 
> Suggested-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> 
> > Reviewed-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> > Signed-off-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> > ---
> > I'd like this to go directly to net-next to quickly unbreak VFs (the
> > related commits are not in the mainline yet).
> Thanks,
> Olek

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>