linux-kernel - Re: [RFT PATCH v2 4/5] pinctrl: samsung: fold GS101 pin-bank macros into EXYNOS9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADrjBPoG_omRShNhwUJZ0yeRLAzQxmGHvO6OzsR2NOfLczoptg@mail.gmail.com>
Date: Mon, 24 Nov 2025 17:22:03 +0000
From: Peter Griffin <peter.griffin@...aro.org>
To: Youngmin Nam <youngmin.nam@...sung.com>
Cc: krzk@...nel.org, s.nawrocki@...sung.com, alim.akhtar@...sung.com, 
	linus.walleij@...aro.org, semen.protsenko@...aro.org, ryu.real@...sung.com, 
	d7271.choe@...sung.com, linux-arm-kernel@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [RFT PATCH v2 4/5] pinctrl: samsung: fold GS101 pin-bank macros
 into EXYNOS9_*

Hi Youngmin,

Thanks for taking the time to do this cleanup!

On Mon, 17 Nov 2025 at 07:36, Youngmin Nam <youngmin.nam@...sung.com> wrote:
>
> GS101 had dedicated GS101_PIN_BANK_EINT{G,W} helpers, but they are
> redundant with EXYNOS9_PIN_BANK_EINT{G,W} (same semantics, including
> the per-bank .eint_fltcon_offset).
> This change removes the GS101_* macros and switches the GS101 pin-bank
> tables to the EXYNOS9_* helpers with exynos9_bank_type_{alive,off}.
> While here, update the struct comment to note FLTCON is Exynos9-specific
> (not 'GS101-specific').
>
> One macro family for all Exynos9-era SoCs (incl. GS101) reduces
> copy-paste drift and keeps the FLTCON handling consistent.
> There is no functional change.
>
> Signed-off-by: Youngmin Nam <youngmin.nam@...sung.com>
> Reviewed-by: Sam Protsenko <semen.protsenko@...aro.org>
> Tested-by: Sam Protsenko <semen.protsenko@...aro.org>
> ---

Reviewed-by: Peter Griffin <peter.griffin@...aro.org>
Tested-by:  Peter Griffin <peter.griffin@...aro.org> (tested on Pixel 6 / gs101)

regards,

Peter