linux-kernel - Re: 回复: [PATCH -next] PCI: cadence: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251124180255.GA2700418@bhelgaas>
Date: Mon, 24 Nov 2025 12:02:55 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Hans Zhang <Hans.Zhang@...tech.com>
Cc: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
	"lpieralisi@...nel.org" <lpieralisi@...nel.org>,
	"kwilczynski@...nel.org" <kwilczynski@...nel.org>,
	"mani@...nel.org" <mani@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Abaci Robot <abaci@...ux.alibaba.com>,
	Manikandan Karunakaran Pillai <mpillai@...ence.com>
Subject: Re: 回复: [PATCH -next] PCI: cadence:
 remove unneeded semicolon

On Thu, Nov 20, 2025 at 09:41:43AM +0000, Hans Zhang wrote:
> + Manikandan
> 
> -----邮件原件-----
> 发件人: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> 
> 发送时间: 2025年11月20日 17:35
> 收件人: lpieralisi@...nel.org
> 抄送: kwilczynski@...nel.org; mani@...nel.org; robh@...nel.org; bhelgaas@...gle.com; linux-pci@...r.kernel.org; linux-kernel@...r.kernel.org; Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>; Abaci Robot <abaci@...ux.alibaba.com>
> 主题: [PATCH -next] PCI: cadence: remove unneeded semicolon
> 
> [You don't often get email from jiapeng.chong@...ux.alibaba.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL
> 
> No functional modification involved.
> 
> ./drivers/pci/controller/cadence/pcie-cadence.h:217:2-3: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=27326
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Squashed this into the commit (f5fa6c33b173 ("PCI: cadence: Add
support for High Perf Architecture (HPA) controller"), no need to
repost this.

There's a rash of this error.  Do you know of any others in
drivers/pci/?

> ---
>  drivers/pci/controller/cadence/pcie-cadence.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/cadence/pcie-cadence.h b/drivers/pci/controller/cadence/pcie-cadence.h
> index 717921411ed9..311a13ae46e7 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence.h
> +++ b/drivers/pci/controller/cadence/pcie-cadence.h
> @@ -214,7 +214,7 @@ static inline u32 cdns_reg_bank_to_off(struct cdns_pcie *pcie, enum cdns_pcie_re
>                 break;
>         default:
>                 break;
> -       };
> +       }
>         return offset;
>  }
> 
> --
> 2.43.5
> 
>