Message-Id: <20251124100436.cad9c3ecd7fc592e8ff23e3a@linux-foundation.org>
Date: Mon, 24 Nov 2025 10:04:36 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Muchun Song <muchun.song@...ux.dev>, Oscar Salvador <osalvador@...e.de>,
 David Hildenbrand <david@...hat.com>, "Liam R . Howlett"
 <Liam.Howlett@...cle.com>, Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport
 <rppt@...nel.org>, Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko
 <mhocko@...e.com>, Axel Rasmussen <axelrasmussen@...gle.com>, Yuanchu Xie
 <yuanchu@...gle.com>, Wei Xu <weixugc@...gle.com>, Peter Xu
 <peterx@...hat.com>, Ingo Molnar <mingo@...hat.com>, Peter Zijlstra
 <peterz@...radead.org>, Juri Lelli <juri.lelli@...hat.com>, Vincent Guittot
 <vincent.guittot@...aro.org>, Dietmar Eggemann <dietmar.eggemann@....com>,
 Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>, Mel
 Gorman <mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>, Kees
 Cook <kees@...nel.org>, Matthew Wilcox <willy@...radead.org>, Jason
 Gunthorpe <jgg@...pe.ca>, John Hubbard <jhubbard@...dia.com>, Leon
 Romanovsky <leon@...nel.org>, Zi Yan <ziy@...dia.com>, Baolin Wang
 <baolin.wang@...ux.alibaba.com>, Nico Pache <npache@...hat.com>, Ryan
 Roberts <ryan.roberts@....com>, Dev Jain <dev.jain@....com>, Barry Song
 <baohua@...nel.org>, Lance Yang <lance.yang@...ux.dev>, Xu Xin
 <xu.xin16@....com.cn>, Chengming Zhou <chengming.zhou@...ux.dev>, Jann Horn
 <jannh@...gle.com>, Matthew Brost <matthew.brost@...el.com>, Joshua Hahn
 <joshua.hahnjy@...il.com>, Rakie Kim <rakie.kim@...com>, Byungchul Park
 <byungchul@...com>, Gregory Price <gourry@...rry.net>, Ying Huang
 <ying.huang@...ux.alibaba.com>, Alistair Popple <apopple@...dia.com>, Pedro
 Falcato <pfalcato@...e.de>, Shakeel Butt <shakeel.butt@...ux.dev>, David
 Rientjes <rientjes@...gle.com>, Rik van Riel <riel@...riel.com>, Harry Yoo
 <harry.yoo@...cle.com>, Kemeng Shi <shikemeng@...weicloud.com>, Kairui Song
 <kasong@...cent.com>, Nhat Pham <nphamcs@...il.com>, Baoquan He
 <bhe@...hat.com>, Chris Li <chrisl@...nel.org>, Johannes Weiner
 <hannes@...xchg.org>, Qi Zheng <zhengqi.arch@...edance.com>,
 linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-mm@...ck.org, Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor
 <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo
 <gary@...yguo.net>, Bjorn Roy Baron <bjorn3_gh@...tonmail.com>, Benno
 Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, Alice
 Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, Danilo
 Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v2 3/4] tools/testing/vma: eliminate dependency on
 vma->__vm_flags

On Mon, 24 Nov 2025 12:43:18 +0000 Lorenzo Stoakes <lorenzo.stoakes@...cle.com> wrote:

> It seems that the ordering of things has messed us up a bit here!
> 
> So this patch (3/4) currently introduces an issue where vm_flags_reset() is
> missing from the VMA userland tests.
> 
> Then 4/4, now with the vma_internal.h fixes in place, puts vm_flags_reset()
> back in place (this was my mistake in the series originally!).
> 
> But then this fix-patch, now applied as the latest patch from me in mm-new,
> breaks the tests again by duplicating this function :)
> 
> So, I'm not sure if too late for rebases - if not, then just squash this
> into 3/4.
> 
> If it is - then just drop this patch altogether and we'll live with this
> being broken for a single commit!

All confused.  I dropped the whole series - please resend?

Powered by blists - more mailing lists