linux-kernel - Re: [PATCH] fs/namespace: correctly handle errors returned by grab_requested_mnt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANaxB-z2hJ3xT7ViA1ERkgFQMaHThgriK_+goMyoNeDtrFBpcQ@mail.gmail.com>
Date: Mon, 24 Nov 2025 11:14:46 -0800
From: Andrei Vagin <avagin@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Andrei Vagin <avagin@...gle.com>, Christian Brauner <brauner@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, Alexander Viro <viro@...iv.linux.org.uk>, 
	Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] fs/namespace: correctly handle errors returned by grab_requested_mnt_ns

On Mon, Nov 24, 2025 at 3:23 AM Mark Brown <broonie@...nel.org> wrote:
>
> On Sun, Nov 23, 2025 at 07:15:16AM -0800, Andrei Vagin wrote:
> > On Sun, Nov 23, 2025 at 4:51 AM Mark Brown <broonie@...nel.org> wrote:
>
> > > listmount04.c:128: TFAIL: invalid mnt_id_req.spare expected EINVAL: EBADF (9)
>
> > The merged patch is slightly different from what you can see on the
> > mailing list, so it's better to look at commit 78f0e33cd6c93
> > ("fs/namespace: correctly handle errors returned by
> > grab_requested_mnt_ns") to understand what is going on here.
>
> > With this patch, the spare field can be used as the `mnt_ns_fd`. EINVAL
> > is returned if both mnt_ns_fd and mnt_ns_id are set. A non-zero
> > mnt_ns_fd (the old spare) is interpreted as a namespace file descriptor.
>
> I can see what's happening - the question is if the test failure it
> triggers is a problem in the kernel or in the test.

This is a test problem. The test has to be modified to check cases when
the target mount namespace is specified by mnt_fs_fd.

Thanks,
Andrei