linux-kernel - Re: [PATCH 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <563ac54a-de2d-49af-a6a6-3230c8070c67@kernel.org>
Date: Mon, 24 Nov 2025 20:53:18 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Neeraj Soni <neeraj.soni@....qualcomm.com>, ulf.hansson@...aro.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 andersson@...nel.org, konradybcio@...nel.org
Cc: linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle

On 24/11/2025 12:19, Neeraj Soni wrote:
> Starting with sc7280(kodiak), the ICE will have its own device-tree node.

$ git grep kodiak
Nothing. Please do not introduce some new namings.



> So add the qcom,ice property to reference it.
> 

...

> +    else:
> +      properties:
> +        reg:
> +          minItems: 2
> +          items:
> +            - description: Host controller register map
> +            - description: SD Core register map
> +            - description: CQE register map
> +            - description: Inline Crypto Engine register map
> +        reg-names:
> +          minItems: 2
> +          items:
> +            - const: hc
> +            - const: core
> +            - const: cqhci
> +            - const: ice

No, look at the binding - it says there are variants without core. You
cannot just rewrite everyone here.

I don't get what you want to achieve here, but the amount of errors this
patch generates should make you think whether it is even correct. Or you
never tested this?

Best regards,
Krzysztof