linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <db24d435-edd7-4b90-99d2-8e62c53340de@kernel.org>
Date: Mon, 24 Nov 2025 20:54:13 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Neeraj Soni <neeraj.soni@....qualcomm.com>, ulf.hansson@...aro.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 andersson@...nel.org, konradybcio@...nel.org
Cc: linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: kodiak: enable the inline crypto
 engine for SDHC

On 24/11/2025 12:19, Neeraj Soni wrote:
> Add an ICE node to kodiak SoC description and enable it by adding a
> phandle to the SDHC node.
> 
> Signed-off-by: Neeraj Soni <neeraj.soni@....qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/kodiak.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> index c2ccbb67f800..9d2029a906ce 100644
> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi
> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> @@ -1069,6 +1069,15 @@ opp-384000000 {
>  					opp-avg-kBps = <390000 0>;
>  				};
>  			};
> +
> +			qcom,ice = <&sdhc_ice>;

This wasn't tested, for sure you have warnings - you placed the property
randomly or at the end (even worse...). Please read DTS coding style as
well.


Best regards,
Krzysztof