linux-kernel - Re: [PATCH V2 2/5] dm: ignore discard return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1ldjv4mdl.fsf@ca-mkp.ca.oracle.com>
Date: Mon, 24 Nov 2025 07:59:58 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Chaitanya Kulkarni <ckulkarnilinux@...il.com>
Cc: axboe@...nel.dk, agk@...hat.com, snitzer@...nel.org, mpatocka@...hat.com,
        song@...nel.org, yukuai@...as.com, hch@....de, sagi@...mberg.me,
        kch@...dia.com, jaegeuk@...nel.org, chao@...nel.org, cem@...nel.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        dm-devel@...ts.linux.dev, linux-raid@...r.kernel.org,
        linux-nvme@...ts.infradead.org, linux-f2fs-devel@...ts.sourceforge.net,
        linux-xfs@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH V2 2/5] dm: ignore discard return value


Chaitanya,

> __blkdev_issue_discard() always returns 0, making all error checking
> at call sites dead code.
>
> For dm-thin change issue_discard() return type to void, in
> passdown_double_checking_shared_status() remove the r assignment from
> return value of the issue_discard(), for end_discard() hardcod value
> of r to 0 that matches only value returned from
> __blkdev_issue_discard().
>
> md part is simplified to only check !discard_bio by ignoring the
> __blkdev_issue_discard() value.

With md and dm split:

Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen