linux-kernel - Re: [PATCH V2 3/5] nvmet: ignore discard return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1fra34m7v.fsf@ca-mkp.ca.oracle.com>
Date: Mon, 24 Nov 2025 08:03:18 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Chaitanya Kulkarni <ckulkarnilinux@...il.com>
Cc: axboe@...nel.dk, agk@...hat.com, snitzer@...nel.org, mpatocka@...hat.com,
        song@...nel.org, yukuai@...as.com, hch@....de, sagi@...mberg.me,
        kch@...dia.com, jaegeuk@...nel.org, chao@...nel.org, cem@...nel.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        dm-devel@...ts.linux.dev, linux-raid@...r.kernel.org,
        linux-nvme@...ts.infradead.org, linux-f2fs-devel@...ts.sourceforge.net,
        linux-xfs@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH V2 3/5] nvmet: ignore discard return value


Chaitanya,

> __blkdev_issue_discard() always returns 0, making the error checking
> in nvmet_bdev_discard_range() dead code.
>
> Kill the function nvmet_bdev_discard_range() and call
> __blkdev_issue_discard() directly from nvmet_bdev_execute_discard(),
> since no error handling is needed anymore for __blkdev_issue_discard()
> call.

Looks good.

Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen