linux-kernel - Re: [PATCH 3/7] dma: mcf-edma: Add per-channel IRQ naming for debugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWDryHHdrsBzsUF4BRhNoDXm4+3FVQ4FV2acGT6reeYhw@mail.gmail.com>
Date: Mon, 24 Nov 2025 14:05:18 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Jean-Michel Hautbois <jeanmichel.hautbois@...eli.org>
Cc: Frank Li <Frank.Li@....com>, Vinod Koul <vkoul@...nel.org>, 
	Greg Ungerer <gerg@...ux-m68k.org>, imx@...ts.linux.dev, dmaengine@...r.kernel.org, 
	linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/7] dma: mcf-edma: Add per-channel IRQ naming for debugging

Hi Jean-Michel,

On Mon, 24 Nov 2025 at 13:52, Jean-Michel Hautbois
<jeanmichel.hautbois@...eli.org> wrote:
> Add dynamic per-channel IRQ naming to make DMA interrupt identification
> easier in /proc/interrupts and debugging tools.
>
> Instead of all channels showing "eDMA", they now show:
> - "eDMA-0" through "eDMA-15" for channels 0-15
> - "eDMA-16" through "eDMA-55" for channels 16-55
> - "eDMA-tx-56" for the shared channel 56-63 interrupt
> - "eDMA-err" for the error interrupt
>
> This aids debugging DMA issues by making it clear which channel's
> interrupt is being serviced.
>
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@...eli.org>

Thanks for your patch!

> --- a/drivers/dma/mcf-edma-main.c
> +++ b/drivers/dma/mcf-edma-main.c
> @@ -81,8 +81,12 @@ static int mcf_edma_irq_init(struct platform_device *pdev,
>         if (!res)
>                 return -1;
>
> -       for (ret = 0, i = res->start; i <= res->end; ++i)
> -               ret |= request_irq(i, mcf_edma_tx_handler, 0, "eDMA", mcf_edma);
> +       for (ret = 0, i = res->start; i <= res->end; ++i) {
> +               char *irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL,
> +                                               "eDMA-%d", i - res->start);

Can return NULL, so needs error handling.

> +
> +               ret |= request_irq(i, mcf_edma_tx_handler, 0, irq_name, mcf_edma);
> +       }
>         if (ret)
>                 return ret;
>
> @@ -91,15 +95,19 @@ static int mcf_edma_irq_init(struct platform_device *pdev,
>         if (!res)
>                 return -1;
>
> -       for (ret = 0, i = res->start; i <= res->end; ++i)
> -               ret |= request_irq(i, mcf_edma_tx_handler, 0, "eDMA", mcf_edma);
> +       for (ret = 0, i = res->start; i <= res->end; ++i) {
> +               char *irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL,
> +                                               "eDMA-%d", 16 + i - res->start);

Likewise

> +
> +               ret |= request_irq(i, mcf_edma_tx_handler, 0, irq_name, mcf_edma);
> +       }
>         if (ret)
>                 return ret;
>
>         ret = platform_get_irq_byname(pdev, "edma-tx-56-63");
>         if (ret != -ENXIO) {
>                 ret = request_irq(ret, mcf_edma_tx_handler,
> -                                 0, "eDMA", mcf_edma);
> +                                 0, "eDMA-tx-56", mcf_edma);

Fits on a single line.

>                 if (ret)
>                         return ret;
>         }
> @@ -107,7 +115,7 @@ static int mcf_edma_irq_init(struct platform_device *pdev,
>         ret = platform_get_irq_byname(pdev, "edma-err");
>         if (ret != -ENXIO) {
>                 ret = request_irq(ret, mcf_edma_err_handler,
> -                                 0, "eDMA", mcf_edma);
> +                                 0, "eDMA-err", mcf_edma);

Likewise.

>                 if (ret)
>                         return ret;
>         }
>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds