linux-kernel - Re: [PATCH 6/6] phy: qcom: sgmii-eth: add second regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c50fd96-74af-4096-b53e-4feb3ab59f06@oss.qualcomm.com>
Date: Mon, 24 Nov 2025 14:31:30 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Mohd Ayaan Anwar <mohd.anwar@....qualcomm.com>,
        Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Wasim Nazir <wasim.nazir@....qualcomm.com>,
        Mohd Ayaan Anwar <quic_mohdayaa@...cinc.com>,
        Yijie Yang <quic_yijiyang@...cinc.com>
Cc: linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] phy: qcom: sgmii-eth: add second regulator support

On 11/24/25 10:25 AM, Mohd Ayaan Anwar wrote:
> The Qualcomm SGMII SerDes PHY requires two regulators to function
> properly. If both of these are not enabled, the following error is
> observed:
> [   77.105651] qcom-dwmac-sgmii-phy 8909000.phy: QSERDES_COM_C_READY_STATUS timed-out
> [   77.113447] qcom-ethqos 23040000.ethernet eth0: __stmmac_open: Serdes powerup failed
> 
> Therefore, add support for handling the additional regulator in the
> driver.
> 
> Fixes: 601d06277007 ("phy: qcom: add the SGMII SerDes PHY driver")
> Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@....qualcomm.com>
> ---

[...]

> -	return clk_prepare_enable(data->refclk);
> +	ret = regulator_enable(data->vdda_0p9);
> +	if (ret)
> +		goto out_ret;

'goto return' can just become 'return'

[...]

> +	data->vdda_0p9 = devm_regulator_get(dev, "vdda-0p9");
> +	if (IS_ERR(data->vdda_0p9))
> +		return PTR_ERR(data->vdda_0p9);

Do we have any conclusions on the load discussion?

Konrad