linux-kernel - Re: [PATCH 1/6] dt-bindings: phy: describe additional regulator for Qualcomm SGMII PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251125-happy-silver-monkey-569cfd@kuoka>
Date: Tue, 25 Nov 2025 10:59:06 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mohd Ayaan Anwar <mohd.anwar@....qualcomm.com>
Cc: Vinod Koul <vkoul@...nel.org>, 
	Kishon Vijay Abraham I <kishon@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Wasim Nazir <wasim.nazir@....qualcomm.com>, 
	Mohd Ayaan Anwar <quic_mohdayaa@...cinc.com>, Yijie Yang <quic_yijiyang@...cinc.com>, 
	linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH 1/6] dt-bindings: phy: describe additional regulator for
 Qualcomm SGMII PHY

On Mon, Nov 24, 2025 at 02:55:17PM +0530, Mohd Ayaan Anwar wrote:
> Describe the additional vdda-0p9-supply for the Qualcomm SGMII PHY.

Why... device was completely described or not? What else is missing?
Please read writing bindings doc - the bindings are supposed to be
complete, so you bringing up properties afterwards feels odd.

> 
> Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@....qualcomm.com>
> ---
>  .../devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml         | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> index 90fc8c039219c739eae05cc17108a9a2fc6193df..0a1330b9118d63cf5400325c58bca05ebc641055 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> @@ -36,6 +36,10 @@ properties:
>      description:
>        Phandle to a regulator that provides power to the PHY.
>  
> +  vdda-0p9-supply:

Why not vdda? What other supplies are you missing?

> +    description:
> +      Phandle to a 0.9V regulator supply to the PHY.

You just duplicated phy-supply, no? Both supply to the phy or how
exactly does it work?

Best regards,
Krzysztof