linux-kernel - Re: [PATCH v3 2/3] i3c: dw: Add sysfs support for Device NACK Retry count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a09b21bd-84b6-435e-b6e0-fe94c9e62f4a@intel.com>
Date: Tue, 25 Nov 2025 16:05:53 +0200
From: Adrian Hunter <adrian.hunter@...el.com>
To: "Ng, Adrian Ho Yin" <adrianhoyin.ng@...era.com>, Frank Li
	<Frank.li@....com>
CC: <alexandre.belloni@...tlin.com>, <linux-i3c@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/3] i3c: dw: Add sysfs support for Device NACK Retry
 count

On 25/11/2025 05:19, Ng, Adrian Ho Yin wrote:
> On 11/25/2025 1:59 AM, Frank Li wrote:
> 
>>> +
>>> +    master->dev_nack_retry_cnt = val;
>>> +
>>> +    spin_lock_irqsave(&master->devs_lock, flags);
>>
>> I think you'd better to hold i3c_bus_maintenance_lock() lock to make
>> sure not transfer on going.
>>
>> Frank
> Hi Frank
> 
> i3c_bus_maintenance_lock is a static function in master.c. So should i update it and expose a public helper to take the maintenance lock or continue using the existing spin lock to protect the DAT updates?
> 
> Thank You
> Adrian

Other controllers (e.g. MIPI I3C) support dev_nack_retry_cnt.

Seems to me this should be in master.c anyway, so it can be shared.