linux-kernel - Re: [PATCH v3 2/3] i3c: dw: Add sysfs support for Device NACK Retry count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f5ff6901-ada5-47ce-822d-11aa35adabc9@altera.com>
Date: Tue, 25 Nov 2025 11:19:58 +0800
From: "Ng, Adrian Ho Yin" <adrianhoyin.ng@...era.com>
To: Frank Li <Frank.li@....com>
Cc: alexandre.belloni@...tlin.com, linux-i3c@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/3] i3c: dw: Add sysfs support for Device NACK Retry
 count

On 11/25/2025 1:59 AM, Frank Li wrote:

>> +
>> +	master->dev_nack_retry_cnt = val;
>> +
>> +	spin_lock_irqsave(&master->devs_lock, flags);
> 
> I think you'd better to hold i3c_bus_maintenance_lock() lock to make
> sure not transfer on going.
> 
> Frank
Hi Frank

i3c_bus_maintenance_lock is a static function in master.c. So should i 
update it and expose a public helper to take the maintenance lock or 
continue using the existing spin lock to protect the DAT updates?

Thank You
Adrian
>> +	/*
>> +	 * Update DAT entries for all currently attached devices.
>> +	 * We directly iterate through the master's device array.
>> +	 */
>> +	for (i = 0; i < master->maxdevs; i++) {
>> +		/* Skip free/empty slots */