linux-kernel - Re: [PATCH net v3] net: lan966x: Fix the initialization of taprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aSW4rWMipK3Qg2iU@horms.kernel.org>
Date: Tue, 25 Nov 2025 14:09:49 +0000
From: Simon Horman <horms@...nel.org>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc: UNGLinuxDriver@...rochip.com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, richardcochran@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v3] net: lan966x: Fix the initialization of taprio

On Fri, Nov 21, 2025 at 07:14:11AM +0100, Horatiu Vultur wrote:
> To initialize the taprio block in lan966x, it is required to configure
> the register REVISIT_DLY. The purpose of this register is to set the
> delay before revisit the next gate and the value of this register depends
> on the system clock. The problem is that the we calculated wrong the value
> of the system clock period in picoseconds. The actual system clock is
> ~165.617754MHZ and this correspond to a period of 6038 pico seconds and
> not 15125 as currently set.
> 
> Fixes: e462b2717380b4 ("net: lan966x: Add offload support for taprio")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> 
> ---
> v2-v3:
> - start to use the define
> 
> v1->v2:
> - add define for system clock and calculate the period in picoseconds

Thanks, I agree with this analysis.
And believe v3 addresses the review of earlier versions.

Reviewed-by: Simon Horman <horms@...nel.org>