linux-kernel - Re: [PATCH] iommu/amd: Propagate the error code returned by __modify_irte_ga() in modify_irte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <rl2w22cx26vca3gi3c64axt2enez6qcna2w4qpfbfjeopjygst@ttvuj6gdgb7v>
Date: Tue, 25 Nov 2025 15:10:46 +0100
From: Jörg Rödel <joro@...tes.org>
To: Jinhui Guo <guojinhui.liam@...edance.com>
Cc: suravee.suthikulpanit@....com, iommu@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] iommu/amd: Propagate the error code returned by
 __modify_irte_ga() in modify_irte_ga()

On Thu, Nov 20, 2025 at 11:47:25PM +0800, Jinhui Guo wrote:
> The return type of __modify_irte_ga() is int, but modify_irte_ga()
> treats it as a bool. Casting the int to bool discards the error code.
> 
> To fix the issue, change the type of ret to int in modify_irte_ga().
> 
> Fixes: 57cdb720eaa5 ("iommu/amd: Do not flush IRTE when only updating isRun and destination fields")
> Cc: stable@...r.kernel.org
> Signed-off-by: Jinhui Guo <guojinhui.liam@...edance.com>
> ---
>  drivers/iommu/amd/iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.