linux-kernel - Re: [PATCH net] platform/x86: intel_pmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72fcaebe-afb6-49ef-a6fd-69aa0f8c7a39@lunn.ch>
Date: Tue, 25 Nov 2025 01:29:33 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: yongxin.liu@...driver.com, LKML <linux-kernel@...r.kernel.org>,
	Netdev <netdev@...r.kernel.org>, david.e.box@...ux.intel.com,
	chao.qin@...el.com, yong.liang.choong@...ux.intel.com,
	kuba@...nel.org, platform-driver-x86@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH net] platform/x86: intel_pmc_ipc: fix ACPI buffer memory
 leak

> Good catch but this fix doesn't address all possible paths. So please use 
> cleanup.h instead:
> 
> 	union acpi_object *obj __free(kfree) = buffer.pointer;
> 
> And don't forget to add the #include.

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

  1.6.5. Using device-managed and cleanup.h constructs¶

  Low level cleanup constructs (such as __free()) can be used when
  building APIs and helpers, especially scoped iterators. However,
  direct use of __free() within networking core and drivers is
  discouraged. Similar guidance applies to declaring variables
  mid-function.

    Andrew

---
pw-bot: cr