linux-kernel - Re: [PATCH v3] HID: memory leak in dualshock4_get_calibration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f67a5702-4b44-41bb-9538-19063bc28b41@gmail.com>
Date: Tue, 25 Nov 2025 20:19:19 +0200
From: Eslam Khafagy <eslam.medhat1993@...il.com>
To: Max Staudt <max@...as.org>, Jiri Slaby <jirislaby@...nel.org>,
 roderick.colenbrander@...y.com, jikos@...nel.org, bentiss@...nel.org
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
 syzbot+4f5f81e1456a1f645bf8@...kaller.appspotmail.com, stable@...r.kernel.org
Subject: Re: [PATCH v3] HID: memory leak in dualshock4_get_calibration_data


On 11/24/25 16:06, Max Staudt wrote:
> On 11/24/25 3:32 PM, Jiri Slaby wrote:
>> Isn't this fixed already by:
>> commit 8513c154f8ad7097653dd9bf43d6155e5aad4ab3
>> Author: Abdun Nihaal <nihaal@....iitm.ac.in>
>> Date:   Mon Nov 10 22:45:50 2025 +0530
>>
>>      HID: playstation: Fix memory leak in 
>> dualshock4_get_calibration_data()
>> ?
>
> As far as I can see, that patch does indeed fix the same issue, and it 
> is already upstream.
>
> Thanks for the hint - Abdun's patch has been upstreamed quite 
> recently, hence I guess Eslam missed it by accident. But maybe I'm 
> wrong and Eslam can chime in himself?
Thank's Max & Jiri,
sorry i was sick the past couple of days i missed your replies.
yes. that patch fixes it. I guess i missed it because it wasn't merged 
yet when i submitted v1.
So please ignore this patch.
>
>
>> Anyway, this is a typical use-case for __free(). Why not to use that?
>
> Wow, there's been a lot of interesting stuff happening around 
> cleanup.h. I've been out of the kernel for too long, this looks like 
> fun. Thanks for pointing it out :)
>
>
> Max 
Lastly, One question to max,
at the beginning of the function  dualshock4_get_calibration_data
buf = kzalloc(DS4_FEATURE_REPORT_CALIBRATION_SIZE, GFP_KERNEL); if 
(!buf) { ret = -ENOMEM; goto transfer_failed; }
if the allocation fails. can't we just return here . or do we need to go 
the the end of the function and do sanity checks at the end?