linux-kernel - Re: [PATCH v3] HID: memory leak in dualshock4_get_calibration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1fb509f-6a3a-411f-a756-03c389eb4335@enpas.org>
Date: Fri, 28 Nov 2025 01:55:29 +0900
From: Max Staudt <max@...as.org>
To: Eslam Khafagy <eslam.medhat1993@...il.com>,
 Jiri Slaby <jirislaby@...nel.org>, roderick.colenbrander@...y.com,
 jikos@...nel.org, bentiss@...nel.org
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
 syzbot+4f5f81e1456a1f645bf8@...kaller.appspotmail.com, stable@...r.kernel.org
Subject: Re: [PATCH v3] HID: memory leak in dualshock4_get_calibration_data


On 11/26/25 3:19 AM, Eslam Khafagy wrote:
> Lastly, One question to max,
> at the beginning of the function  dualshock4_get_calibration_data
> buf = kzalloc(DS4_FEATURE_REPORT_CALIBRATION_SIZE, GFP_KERNEL); if (! 
> buf) { ret = -ENOMEM; goto transfer_failed; }
> if the allocation fails. can't we just return here

Never.


> or do we need to go the the end of the function and do sanity checks
> at the end?

Correct.


Without the sanitisation code, the driver will divide by zero.



Max