linux-kernel - Re: [PATCH v2 1/2] rv: Convert to use lock guard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251125145736.48c3ed9d@gandalf.local.home>
Date: Tue, 25 Nov 2025 14:57:36 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Nam Cao <namcao@...utronix.de>
Cc: Gabriele Monaco <gmonaco@...hat.com>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] rv: Convert to use lock guard

On Mon, 17 Nov 2025 09:06:02 +0000
Nam Cao <namcao@...utronix.de> wrote:

> @@ -644,13 +640,11 @@ static ssize_t enabled_monitors_write(struct file *filp, const char __user *user
>  		else
>  			retval = rv_disable_monitor(mon);
>  
> -		if (!retval)
> -			retval = count;
> -
> -		break;
> +		if (retval)
> +			return retval;
> +		return count;

No biggy, but I wonder if this would look better as:

		return retval ? : count;

-- Steve

>  	}
>  
> -	mutex_unlock(&rv_interface_lock);
>  	return retval;
>  }
>