linux-kernel - Re: [PATCH v2 1/2] rv: Convert to use lock guard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4838dd91f14024222eef8e705f2b1ae7945bb80.camel@redhat.com>
Date: Wed, 26 Nov 2025 08:27:42 +0100
From: Gabriele Monaco <gmonaco@...hat.com>
To: Steven Rostedt <rostedt@...dmis.org>, Nam Cao <namcao@...utronix.de>
Cc: Masami Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers
	 <mathieu.desnoyers@...icios.com>, linux-trace-kernel@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] rv: Convert to use lock guard

On Tue, 2025-11-25 at 14:57 -0500, Steven Rostedt wrote:
> On Mon, 17 Nov 2025 09:06:02 +0000
> Nam Cao <namcao@...utronix.de> wrote:
> 
> > @@ -644,13 +640,11 @@ static ssize_t enabled_monitors_write(struct file
> > *filp, const char __user *user
> >  		else
> >  			retval = rv_disable_monitor(mon);
> >  
> > -		if (!retval)
> > -			retval = count;
> > -
> > -		break;
> > +		if (retval)
> > +			return retval;
> > +		return count;
> 
> No biggy, but I wonder if this would look better as:
> 
> 		return retval ? : count;
> 

Tried both patches and they look fine to me.

Reviewed-by: Gabriele Monaco <gmonaco@...hat.com>

Nam, feel free to send an updated version if you want to apply Steve's
suggestion or keep the patch like this.

Steve, this is the only remaining change before the merge window, unless you
prefer to keep it for the next round, I'm going to send a small pull requests
with those two patches alone.

Thanks,
Gabriele

> -- Steve
> 
> >  	}
> >  
> > -	mutex_unlock(&rv_interface_lock);
> >  	return retval;
> >  }
> >