linux-kernel - Re: [PATCH V3 5/6] f2fs: ignore discard return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c8a6b5f-74c8-4e9f-ae46-24e1df5fe4e0@kernel.org>
Date: Tue, 25 Nov 2025 09:10:00 +0800
From: Chao Yu <chao@...nel.org>
To: Chaitanya Kulkarni <ckulkarnilinux@...il.com>, axboe@...nel.dk,
 agk@...hat.com, snitzer@...nel.org, mpatocka@...hat.com, song@...nel.org,
 yukuai@...as.com, hch@....de, sagi@...mberg.me, kch@...dia.com,
 jaegeuk@...nel.org, cem@...nel.org
Cc: chao@...nel.org, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org, dm-devel@...ts.linux.dev,
 linux-raid@...r.kernel.org, linux-nvme@...ts.infradead.org,
 linux-f2fs-devel@...ts.sourceforge.net, linux-xfs@...r.kernel.org,
 bpf@...r.kernel.org, "Martin K . Petersen" <martin.petersen@...cle.com>,
 Johannes Thumshirn <johannes.thumshirn@....com>
Subject: Re: [PATCH V3 5/6] f2fs: ignore discard return value

On 11/25/2025 7:48 AM, Chaitanya Kulkarni wrote:
> __blkdev_issue_discard() always returns 0, making the error assignment
> in __submit_discard_cmd() dead code.
> 
> Initialize err to 0 and remove the error assignment from the
> __blkdev_issue_discard() call to err. Move fault injection code into
> already present if branch where err is set to -EIO.
> 
> This preserves the fault injection behavior while removing dead error
> handling.
> 
> Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>
> Reviewed-by: Christoph Hellwig <hch@....de>
> Signed-off-by: Chaitanya Kulkarni <ckulkarnilinux@...il.com>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,