linux-kernel - [PATCH 2/2] remoteproc: imx_dsp_rproc: Wait for suspend ACK only if WAIT_FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20251125124903.962295-2-iuliana.prodan@oss.nxp.com>
Date: Tue, 25 Nov 2025 14:49:03 +0200
From: "Iuliana Prodan (OSS)" <iuliana.prodan@....nxp.com>
To: Bjorn Andersson <andersson@...nel.org>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	"S.J. Wang" <shengjiu.wang@....com>,
	Fabio Estevam <festevam@...il.com>,
	Daniel Baluta <daniel.baluta@....com>,
	Iuliana Prodan <iuliana.prodan@....com>
Cc: imx@...ts.linux.dev,
	linux-remoteproc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Pengutronix Kernel Team <kernel@...gutronix.de>
Subject: [PATCH 2/2] remoteproc: imx_dsp_rproc: Wait for suspend ACK only if WAIT_FW_READY is set

From: Iuliana Prodan <iuliana.prodan@....com>

The DSP suspend path currently waits unconditionally
for a suspend ack from the firmware.
This breaks firmwares that do not implement the
mailbox-based READY handshake, as the DSP never
responds and system suspend fails with -EBUSY.

The driver already uses the WAIT_FW_READY flag to
indicate that the firmware supports the READY
handshake at boot. Apply the same logic during
suspend: only wait for the suspend ack when the
firmware is expected to support it.

Signed-off-by: Iuliana Prodan <iuliana.prodan@....com>
---
 drivers/remoteproc/imx_dsp_rproc.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
index fc0470aa72c1..e25dbe32ef79 100644
--- a/drivers/remoteproc/imx_dsp_rproc.c
+++ b/drivers/remoteproc/imx_dsp_rproc.c
@@ -1327,10 +1327,11 @@ static int imx_dsp_suspend(struct device *dev)
 	}
 
 	/*
-	 * DSP need to save the context at suspend.
-	 * Here waiting the response for DSP, then power can be disabled.
+	 * The DSP must save its context during suspend.
+	 * Wait for a response from the DSP if required before disabling power.
 	 */
-	if (!wait_for_completion_timeout(&priv->pm_comp, msecs_to_jiffies(100)))
+	if (priv->flags & WAIT_FW_READY &&
+	    !wait_for_completion_timeout(&priv->pm_comp, msecs_to_jiffies(100)))
 		return -EBUSY;
 
 out:
-- 
2.34.1