linux-kernel - Re: [PATCH 1/2] liveupdate: luo_session: Fix uninitialized variable in luo_session_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+CK2bBpMf12yQPcqfjfZgsw2W4ctShPveK348HPSBekUaV8qQ@mail.gmail.com>
Date: Wed, 26 Nov 2025 10:22:28 -0500
From: Pasha Tatashin <pasha.tatashin@...een.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Mike Rapoport <rppt@...nel.org>, Pratyush Yadav <pratyush@...nel.org>, 
	Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] liveupdate: luo_session: Fix uninitialized variable
 in luo_session_setup_outgoing()

On Wed, Nov 26, 2025 at 9:51 AM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> The "header_ser" variable is uninitialized.  The "outgoing_buffer"
> variable was intended here, so use that instead.
>
> Fixes: 7eeeec7e1690 ("liveupdate: luo_session: add sessions support")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  kernel/liveupdate/luo_session.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/liveupdate/luo_session.c b/kernel/liveupdate/luo_session.c
> index cf5c83b272e7..a572bf689712 100644
> --- a/kernel/liveupdate/luo_session.c
> +++ b/kernel/liveupdate/luo_session.c
> @@ -447,7 +447,7 @@ int __init luo_session_setup_outgoing(void *fdt_out)
>
>         outgoing_buffer = kho_alloc_preserve(LUO_SESSION_PGCNT << PAGE_SHIFT);
>         if (IS_ERR(outgoing_buffer))
> -               return PTR_ERR(header_ser);
> +               return PTR_ERR(outgoing_buffer);
>         header_ser = outgoing_buffer;
>         header_ser_pa = virt_to_phys(header_ser);

This is already fixed in LUOv8.

Thank you,
Pasha

>
> --
> 2.51.0
>