linux-kernel - Re: [PATCH 2/2] liveupdate: luo_session: Fix use after free in luo_session

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+CK2bB1Usw5Z7NkiPLHHYCJPEao0KPR1suf_4=hGi+3oOwDKg@mail.gmail.com>
Date: Wed, 26 Nov 2025 10:23:55 -0500
From: Pasha Tatashin <pasha.tatashin@...een.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Mike Rapoport <rppt@...nel.org>, Pratyush Yadav <pratyush@...nel.org>, 
	Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] liveupdate: luo_session: Fix use after free in luo_session_deserialize()

On Wed, Nov 26, 2025 at 9:51 AM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> The debug output frees "session" but it was freed on the previous line.
> Move the free after the printk().
>
> Fixes: 7eeeec7e1690 ("liveupdate: luo_session: add sessions support")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  kernel/liveupdate/luo_session.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/liveupdate/luo_session.c b/kernel/liveupdate/luo_session.c
> index a572bf689712..b86d45c9dcbd 100644
> --- a/kernel/liveupdate/luo_session.c
> +++ b/kernel/liveupdate/luo_session.c
> @@ -553,9 +553,9 @@ int luo_session_deserialize(void)
>
>                 err = luo_session_insert(sh, session);
>                 if (err) {
> -                       luo_session_free(session);
>                         pr_warn("Failed to insert session [%s] %pe\n",
>                                 session->name, ERR_PTR(err));
> +                       luo_session_free(session);
>                         return err;
>                 }

Andrew, could you please add this fix-up to "liveupdate: luo_session:
add sessions support"

Thank you,
Pasha

>
> --
> 2.51.0
>