linux-kernel - Re: [PATCH v8 23/52] perf jevents: Add uncore l3 metric group for AMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abb4a851-319a-4c2f-a99d-c4e352ceb1ab@amd.com>
Date: Wed, 26 Nov 2025 10:50:44 +0530
From: Sandipan Das <sandipan.das@....com>
To: Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Benjamin Gray <bgray@...ux.ibm.com>, Caleb Biggers
 <caleb.biggers@...el.com>, Edward Baker <edward.baker@...el.com>,
 Ingo Molnar <mingo@...hat.com>, James Clark <james.clark@...aro.org>,
 Jing Zhang <renyu.zj@...ux.alibaba.com>, Jiri Olsa <jolsa@...nel.org>,
 John Garry <john.g.garry@...cle.com>, Leo Yan <leo.yan@....com>,
 Namhyung Kim <namhyung@...nel.org>, Perry Taylor <perry.taylor@...el.com>,
 Peter Zijlstra <peterz@...radead.org>, Samantha Alt
 <samantha.alt@...el.com>, Thomas Falcon <thomas.falcon@...el.com>,
 Weilin Wang <weilin.wang@...el.com>, Xu Yang <xu.yang_2@....com>,
 linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v8 23/52] perf jevents: Add uncore l3 metric group for AMD

On 11/13/2025 8:50 AM, Ian Rogers wrote:
> Metrics use the amd_l3 PMU for access/miss/hit information.
> 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/pmu-events/amd_metrics.py | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/tools/perf/pmu-events/amd_metrics.py b/tools/perf/pmu-events/amd_metrics.py
> index 1592d7db2ac7..d748b5c1d791 100755
> --- a/tools/perf/pmu-events/amd_metrics.py
> +++ b/tools/perf/pmu-events/amd_metrics.py
> @@ -479,6 +479,24 @@ def Rapl() -> MetricGroup:
>                         description="Processor socket power consumption estimates")
>  
>  
> +def UncoreL3():
> +    acc = Event("l3_lookup_state.all_coherent_accesses_to_l3",
> +                "l3_lookup_state.all_l3_req_typs")
> +    miss = Event("l3_lookup_state.l3_miss",
> +                 "l3_comb_clstr_state.request_miss")
> +    acc = max(acc, miss)
> +    hits = acc - miss
> +
> +    return MetricGroup("lpm_l3", [
> +        Metric("lpm_l3_accesses", "L3 victim cache accesses",
> +               d_ratio(acc, interval_sec), "accesses/sec"),
> +        Metric("lpm_l3_hits", "L3 victim cache hit rate",
> +               d_ratio(hits, acc), "100%"),
> +        Metric("lpm_l3_miss", "L3 victim cache miss rate", d_ratio(miss, acc),
> +               "100%"),
> +    ], description="L3 cache breakdown per CCX")
> +
> +
>  def main() -> None:
>      global _args
>      global _zen_model
> @@ -515,6 +533,7 @@ def main() -> None:
>          AmdUpc(),
>          Idle(),
>          Rapl(),
> +        UncoreL3(),
>      ])
>  
>      if _args.metricgroups:

Would it be possible to include the L3 read miss latency metric here?

Reviewed-by: Sandipan Das <sandipan.das@....com>