linux-kernel - Re: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add compatible string for Agilex5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e049a03a-49e3-4b00-a3e8-7560f63fa61a@altera.com>
Date: Wed, 26 Nov 2025 07:43:42 +0000
From: "Romli, Khairul Anuar" <khairul.anuar.romli@...era.com>
To: Rob Herring <robh@...nel.org>
CC: Dinh Nguyen <dinguyen@...nel.org>, Vinod Koul <vkoul@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add compatible
 string for Agilex5

On 21/11/2025 1:36 am, Rob Herring wrote:
> On Thu, Nov 20, 2025 at 07:31:10PM +0800, Khairul Anuar Romli wrote:
>> The address bus on Agilex5 is limited to 40 bits. When SMMU is enable this
>> will cause address truncation and translation faults. Hence introducing
>> "altr,agilex5-axi-dma" to enable platform specific configuration to
>> configure the dma addressable bit mask.
> 
> That's likely a bus limitation, not an IP limitation. So that should be
> handled with dma-ranges.
> 
> However, adding a specific compatible is perfectly fine.
> 
Would it be okay if I rephrase and send the next version with a 
correction in the commit message body as your comment in this version?

Thanks.

Regards,
Khairul
>>
>> Add a fallback capability for the compatible property to allow driver to
>> probe and initialize with a newly added compatible string without requiring
>> additional entry in the driver.
>>
>> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
>> ---
>>   .../devicetree/bindings/dma/snps,dw-axi-dmac.yaml  | 14 +++++++++-----
>>   1 file changed, 9 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> index a393a33c8908..db89ebf2b006 100644
>> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> @@ -17,11 +17,15 @@ allOf:
>>   
>>   properties:
>>     compatible:
>> -    enum:
>> -      - snps,axi-dma-1.01a
>> -      - intel,kmb-axi-dma
>> -      - starfive,jh7110-axi-dma
>> -      - starfive,jh8100-axi-dma
>> +    oneOf:
>> +      - enum:
>> +          - snps,axi-dma-1.01a
>> +          - intel,kmb-axi-dma
>> +          - starfive,jh7110-axi-dma
>> +          - starfive,jh8100-axi-dma
>> +      - items:
>> +          - const: altr,agilex5-axi-dma
>> +          - const: snps,axi-dma-1.01a
>>   
>>     reg:
>>       minItems: 1
>> -- 
>> 2.43.7
>>