linux-kernel - Re: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add compatible string for Agilex5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251126-frisky-puma-from-valhalla-e3ee05@kuoka>
Date: Wed, 26 Nov 2025 10:41:01 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Romli, Khairul Anuar" <khairul.anuar.romli@...era.com>
Cc: Rob Herring <robh@...nel.org>, Dinh Nguyen <dinguyen@...nel.org>, 
	Vinod Koul <vkoul@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add compatible
 string for Agilex5

On Wed, Nov 26, 2025 at 07:43:42AM +0000, Romli, Khairul Anuar wrote:
> On 21/11/2025 1:36 am, Rob Herring wrote:
> > On Thu, Nov 20, 2025 at 07:31:10PM +0800, Khairul Anuar Romli wrote:
> >> The address bus on Agilex5 is limited to 40 bits. When SMMU is enable this
> >> will cause address truncation and translation faults. Hence introducing
> >> "altr,agilex5-axi-dma" to enable platform specific configuration to
> >> configure the dma addressable bit mask.
> > 
> > That's likely a bus limitation, not an IP limitation. So that should be
> > handled with dma-ranges.
> > 
> > However, adding a specific compatible is perfectly fine.
> > 
> Would it be okay if I rephrase and send the next version with a 
> correction in the commit message body as your comment in this version?

Yes and your DTS patch might need changes - include proper dma-ranges.

I also do not see how separate compatible without any driver change
solved your case. That's a no-op patch from Linux driver point of view.

See also submitting patches in DT dir about the process how patches are
grouped together.

Best regards,
Krzysztof