linux-kernel - Re: [PATCH] dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/V2N SoC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8t=T3s3bM6Tkt_E+oWr3O620bmouYNcF_kq=GGX=FT8PA@mail.gmail.com>
Date: Wed, 26 Nov 2025 11:27:55 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	Biju Das <biju.das.jz@...renesas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH] dt-bindings: interrupt-controller: renesas,rzv2h-icu:
 Document RZ/V2N SoC support

Hi Geert,

Thank you for the review.

On Wed, Nov 26, 2025 at 11:22 AM Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Tue, 25 Nov 2025 at 22:32, Prabhakar <prabhakar.csengg@...il.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Document the Interrupt Control Unit (ICU) on the Renesas RZ/V2N SoC,
> > which is architecturally identical to the ICU used on the RZ/V2H(P)
> > SoC.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml
> > @@ -20,9 +20,14 @@ description:
> >
> >  properties:
> >    compatible:
> > -    enum:
> > -      - renesas,r9a09g047-icu # RZ/G3E
> > -      - renesas,r9a09g057-icu # RZ/V2H(P)
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - renesas,r9a09g047-icu # RZ/G3E
> > +              - renesas,r9a09g057-icu # RZ/V2H(P)
> > +      - items:
> > +          - const: renesas,r9a09g056-icu # RZ/V2N
> > +          - const: renesas,r9a09g057-icu
>
> Given ICU on RZ/V2H has lots of extra registers compared to RZ/V2N,
> I think it would be better to drop the fallback.
>
Agreed, I had missed that. Currently the driver does not handle these
regs but in future we could so it's better to split out.

Cheers,
Prabhakar

> >
> >    '#interrupt-cells':
> >      description: The first cell is the SPI number of the NMI or the
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds