linux-kernel - Re: [PATCH v2 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <jqfu76ojoznc7xgyevuzmj7fg3necrr5cp645ye5zk652ytx5w@s4yaxzcq7jzt>
Date: Thu, 27 Nov 2025 21:01:51 +0100
From: Lukas Timmermann <linux@...mermann.space>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Alim Akhtar <alim.akhtar@...sung.com>, Rob Herring <robh@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Russell King <linux@...linux.org.uk>, 
	linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Alexandre Marquet <tb@...arquet.fr>
Subject: Re: [PATCH v2 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

On Wed, Nov 26, 2025 at 10:10:46AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Nov 25, 2025 at 04:12:41PM +0100, Lukas Timmermann wrote:
> > +/ {
> > +	model = "Google Nexus 10";
> > +	compatible = "google,manta", "samsung,exynos5250", "samsung,exynos5";
> > +
> 
> Everything looks good in general, thanks for working on this. I have
> few nits below. You can send next version whenever you are ready, but
> just to let you know - my tree is already closed till RC1.
> 
First of all, thank you!
The as3668 bindings are yet to be applied, no need to rush here.
> > +	aliases {
> > +		mmc0 = &mmc_0; /* eMMC */
> > +		mmc1 = &mmc_1; /* WiFi */
> > +	};
> > +
> > +	memory@...00000 {
> 
> Please order the nodes in top level by node name (see DTS coding style).
> I know that existing files do not follow that, but we try to have new
> code conforming to the coding style.
> 
We ordered them as seen in other devices. I've checked out the coding style 
guideline and will make modifications accordingly.
> > +		device_type = "memory";
> > +		reg = <0x40000000 0x20000000
> 
> Separate <> for each entry.
> 
Acknowledged.
> > +		       0x60000000 0x20000000
> > +		       0x80000000 0x20000000
> > +		       0xa0000000 0x1ff00000>;
> > +	};
> > +
> > +	chosen {
> > +		stdout-path = &serial_2;
> > +	};
> > +
> > +	firmware@...f000 {
> > +		compatible = "samsung,secure-firmware";
> > +		reg = <0x0204f000 0x1000>;
> > +	};
> > +
> > +	fixed-rate-clocks {
> > +		xxti {
> > +			compatible = "samsung,clock-xxti";
> > +			clock-frequency = <24000000>;
> > +		};
> > +
> > +		xusbxti {
> > +			compatible = "samsung,clock-xusbxti";
> 
> Are you sure you have this clock input? I think on Exynos5250 usually
> only XXTI was provided, no?
> 
We checked with the downstream code and found this clock input. We
recognize, that downstream kernels aren't 100% correct at times.
I tested the device without this clock input as you suggested.
It seems that this is in fact not needed. So I will remove it in v3.
> > +			clock-frequency = <24000000>;
> > +		};
> > +	};
> > +
> > +	gpio-keys {
> > +		compatible = "gpio-keys";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&gpio_keys>;
> > +
> > +		key-down {
> > +			gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
> > +			linux,code = <KEY_VOLUMEDOWN>;
> > +			label = "volume down";
> > +			debounce-interval = <5>;
> > +		};
> > +
> > +		key-up {
> > +			gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
> > +			linux,code = <KEY_VOLUMEUP>;
> > +			label = "volume up";
> > +			debounce-interval = <5>;
> > +		};
> > +
> > +		key-power {
> > +			gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
> > +			linux,code = <KEY_POWER>;
> > +			label = "power";
> > +			debounce-interval = <5>;
> > +			wakeup-source;
> > +		};
> > +
> > +		lid-switch {
> > +			label = "Lid";
> > +			gpios = <&gpx1 3 GPIO_ACTIVE_LOW>;
> > +			linux,input-type = <5>; /* EV_SW */
> > +			linux,code = <0>; /* SW_LID */
> > +			debounce-interval = <10>;
> > +			wakeup-source;
> > +		};
> > +	};
> > +
> > +	multi-led {
> > +		compatible = "leds-group-multicolor";
> > +		color = <LED_COLOR_ID_RGB>;
> > +		function = LED_FUNCTION_STATUS;
> > +		leds = <&status_red>, <&status_green>, <&status_blue>, <&status_white>;
> > +	};
> > +
> > +	wlan_pwrseq: mmc1-pwrseq {
> 
> Just "pwrseq"
> 
Acknowledged.
Just out of curiosity. Why is that?
> Best regards,
> Krzysztof
> 
> 
Best regards,
Lukas Timmermann