linux-kernel - Re: [PATCH v2 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9ff65dc6-6f13-47f0-966c-f9885288843e@kernel.org>
Date: Fri, 28 Nov 2025 10:01:44 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Lukas Timmermann <linux@...mermann.space>
Cc: Alim Akhtar <alim.akhtar@...sung.com>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Russell King <linux@...linux.org.uk>,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Alexandre Marquet <tb@...arquet.fr>
Subject: Re: [PATCH v2 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

On 27/11/2025 21:01, Lukas Timmermann wrote:
>>> +
>>> +		lid-switch {
>>> +			label = "Lid";
>>> +			gpios = <&gpx1 3 GPIO_ACTIVE_LOW>;
>>> +			linux,input-type = <5>; /* EV_SW */
>>> +			linux,code = <0>; /* SW_LID */
>>> +			debounce-interval = <10>;
>>> +			wakeup-source;
>>> +		};
>>> +	};
>>> +
>>> +	multi-led {
>>> +		compatible = "leds-group-multicolor";
>>> +		color = <LED_COLOR_ID_RGB>;
>>> +		function = LED_FUNCTION_STATUS;
>>> +		leds = <&status_red>, <&status_green>, <&status_blue>, <&status_white>;
>>> +	};
>>> +
>>> +	wlan_pwrseq: mmc1-pwrseq {
>>
>> Just "pwrseq"
>>
> Acknowledged.
> Just out of curiosity. Why is that?


You have only one pwrseq device, so not need to precise which one is
that and node names should be generic.

https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Best regards,
Krzysztof