linux-kernel - Re: [PATCH v2 3/3] sched/fair: update rq->avg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72a32cac-29dc-41b7-a318-84345a55ed45@amd.com>
Date: Thu, 27 Nov 2025 11:21:15 +0530
From: K Prateek Nayak <kprateek.nayak@....com>
To: Huang Shijie <shijie@...amperecomputing.com>, <mingo@...hat.com>,
	<peterz@...radead.org>, <juri.lelli@...hat.com>, <vincent.guittot@...aro.org>
CC: <patches@...erecomputing.com>, <cl@...ux.com>,
	<Shubhang@...amperecomputing.com>, <dietmar.eggemann@....com>,
	<rostedt@...dmis.org>, <bsegall@...gle.com>, <mgorman@...e.de>,
	<linux-kernel@...r.kernel.org>, <vschneid@...hat.com>,
	<vineethr@...ux.ibm.com>
Subject: Re: [PATCH v2 3/3] sched/fair: update rq->avg_idle for the
 delay-dequeue task

On 11/27/2025 10:33 AM, Huang Shijie wrote:
> When a delay-dequeue task is woken and requeued back, it may
> becomes eligible, and changes the CPU idle status,
> so we need to update the rq->avg_idle for it.
> 
> This patch adds a new parameter for requeue_delayed_entity(),
> and updates the rq->avg_idle as needed.

Can't this be solved by moving update_rq_avg_idle() into
enqueue_task() in the previous patch? The only path that can
reenqueue a delayed task from ttwu_runnable() calls
enqueue_task() with ENQUEUE_DELAYED.

-- 
Thanks and Regards,
Prateek