linux-kernel - Re: [PATCH v3 2/2] ARM: dts: Add support for pcb8385

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251127092450.h3t5vxdfvseartx2@DEN-DL-M31836.microchip.com>
Date: Thu, 27 Nov 2025 10:24:50 +0100
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
	<nicolas.ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
	<claudiu.beznea@...on.dev>, <wsa+renesas@...g-engineering.com>,
	<Ryan.Wanner@...rochip.com>, <romain.sioen@...rochip.com>,
	<devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] ARM: dts: Add support for pcb8385

The 11/26/2025 11:24, Krzysztof Kozlowski wrote:
> 

Hi Krzysztof,

> > +
> > +&flx0 {
> > +     atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>;
> > +     status = "okay";
> > +
> > +     i2c0: i2c@600 {
> 
> You added a label, so this feels like a new node, but then you miss
> compatible and status feels redundant.

Ah.. OK. I didn't want to add a new node.

> 
> If this is override, you should rather override by labels/phandles in
> the first place. Even when overriding by full node path, you should not
> add custom labels - they belong to the base SoC.

I can remove the label.
So, when I want to override or extend with new properties I should
labels?

> 
> > +             pinctrl-0 = <&fc0_b_pins>;
> > +             pinctrl-names = "default";
> > +             dmas = <0>, <0>;
> > +             i2c-analog-filter;
> > +             i2c-digital-filter;
> > +             i2c-digital-filter-width-ns = <35>;
> > +             i2c-sda-hold-time-ns = <1500>;
> > +             status = "okay";
> 
> > +
> > +             eeprom@54 {
> > +                     compatible = "atmel,24c01";
> > +                     reg = <0x54>;
> > +                     status = "okay";
> 
> Why? Was it disabled anywhere?

It wasn't disabled anywhere. I will remove this.

> 
> > +             };
> > +
> > +             eeprom@55 {
> > +                     compatible = "atmel,24c01";
> > +                     reg = <0x55>;
> > +                     status = "okay";
> > +             };
> > +     };
> > +};
> > +
> 
> 
> 
> Best regards,
> Krzysztof

-- 
/Horatiu