linux-kernel - Re: [PATCH v3 2/2] ARM: dts: Add support for pcb8385

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da46dd3f-7259-40a6-b9cd-2586ee5a4aed@kernel.org>
Date: Fri, 28 Nov 2025 10:08:45 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
 claudiu.beznea@...on.dev, wsa+renesas@...g-engineering.com,
 Ryan.Wanner@...rochip.com, romain.sioen@...rochip.com,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] ARM: dts: Add support for pcb8385

On 27/11/2025 10:24, Horatiu Vultur wrote:
> The 11/26/2025 11:24, Krzysztof Kozlowski wrote:
>>
> 
> Hi Krzysztof,
> 
>>> +
>>> +&flx0 {
>>> +     atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>;
>>> +     status = "okay";
>>> +
>>> +     i2c0: i2c@600 {
>>
>> You added a label, so this feels like a new node, but then you miss
>> compatible and status feels redundant.
> 
> Ah.. OK. I didn't want to add a new node.
> 
>>
>> If this is override, you should rather override by labels/phandles in
>> the first place. Even when overriding by full node path, you should not
>> add custom labels - they belong to the base SoC.
> 
> I can remove the label.
> So, when I want to override or extend with new properties I should
> labels?


Yes, child of serial engine should still be extended by label/phandle,
unless this SoC subsystem has different rule.

Best regards,
Krzysztof