linux-kernel - Re: [PATCH] kbuild: add target to build a cpio containing modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSdrCFkUQup3qb-q@derry.ads.avm.de>
Date: Wed, 26 Nov 2025 22:03:04 +0100
From: Nicolas Schier <nsc@...nel.org>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Ahmad Fatoum <a.fatoum@...gutronix.de>, Simon Glass <sjg@...omium.org>,
	Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	linux-kbuild@...r.kernel.org, Sascha Hauer <s.hauer@...gutronix.de>
Subject: Re: [PATCH] kbuild: add target to build a cpio containing modules

On Wed, Nov 19, 2025 at 11:39:36PM -0700, Nathan Chancellor wrote:
...
> > diff --git a/scripts/Makefile.package b/scripts/Makefile.package
> > index 74bcb9e7f7a4516473481468a0fcf700c3bead33..20eec9e2dec4dda3fa0ef64a15b80dccdcb55f90 100644
> > --- a/scripts/Makefile.package
> > +++ b/scripts/Makefile.package
> > @@ -189,6 +189,22 @@ tar-pkg: linux-$(KERNELRELEASE)-$(ARCH).tar
> >  tar%-pkg: linux-$(KERNELRELEASE)-$(ARCH).tar.% FORCE
> >  	@:
> >  
> > +modules-install: FORCE
> > +	$(Q)$(MAKE) -f $(srctree)/Makefile
> > +	$(Q)rm -rf $@
> > +	$(Q)$(MAKE) -f $(srctree)/Makefile INSTALL_MOD_PATH=$@ modules_install
> > +
> > +quiet_cmd_cpio = CPIO    $@
> > +      cmd_cpio = $(srctree)/usr/gen_initramfs.sh $< > $@
> > +
> > +modules-$(KERNELRELEASE)-$(ARCH).cpio: modules-install
> > +	$(Q)$(MAKE) -f $(srctree)/Makefile $(build)=usr cpio-data= usr/gen_init_cpio
> 
> This seems like a bit of a hack to generate gen_init_cpio this way but I
> am not sure it is worth moving usr/gen_init_cpio.c and
> usr/gen_initramfs.sh elsewhere (scripts?) to make it a most accessible
> hostprog right now... Nicolas, do you have any opinions on this?

Yes, it feels hacky to me, too.  After digging into this a bit, I am in
favor of moving at least gen_init* and friends to scripts/.  I can
prepare a patch in a few days.

Kind regards,
Nicolas