linux-kernel - Re: [PATCH] clk: Disable KUNIT_UML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3340d34175e0a18675d7460576c7fe7a2623e2e.camel@sipsolutions.net>
Date: Fri, 28 Nov 2025 08:44:40 +0100
From: Johannes Berg <johannes@...solutions.net>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>, Michael Turquette	
 <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Thomas
 Weißschuh <thomas.weissschuh@...utronix.de>, David Gow
 <davidgow@...gle.com>, Shuah Khan <skhan@...uxfoundation.org>,  Brian
 Masney <bmasney@...hat.com>
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, Peng Fan
	 <peng.fan@....com>
Subject: Re: [PATCH] clk: Disable KUNIT_UML_PCI

> 
> commit 031cdd3bc3f3 ("kunit: Enable PCI on UML without triggering WARN()")
> causes clk gate test fail. Deselect KUNIT_UML_PCI to avoid the failure.

While probably _true_ that this "caused" it, it also seems a bit
dishonest to blame it on that without giving any information as to why
the clk tests trigger some edge case or so?

FTR, the warning only happens when you pass an address to ioread(),
iowrite() or similar that wasn't obtained from ioremap(). Which ought to
not be valid, and I'm pretty convinced that a unit test should never
even end up here.

So no, I don't think this is a valid change, I think the clk unit tests
that end up doing readl() in the gate code for a non-existing device are
broken.

johannes