linux-kernel - Re: [PATCH] clk: Disable KUNIT_UML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251128082930-a0343b02-715c-446d-a879-57526a765191@linutronix.de>
Date: Fri, 28 Nov 2025 09:13:51 +0100
From: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, David Gow <davidgow@...gle.com>, 
	Johannes Berg <johannes@...solutions.net>, Shuah Khan <skhan@...uxfoundation.org>, 
	Brian Masney <bmasney@...hat.com>, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Peng Fan <peng.fan@....com>
Subject: Re: [PATCH] clk: Disable KUNIT_UML_PCI

On Fri, Nov 28, 2025 at 12:14:48PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> commit 031cdd3bc3f3 ("kunit: Enable PCI on UML without triggering WARN()")
> causes clk gate test fail. Deselect KUNIT_UML_PCI to avoid the failure.

One relevant bit for the commit message is that CONFIG_UML_PCI_OVER_VIRTIO is
also disabled in this .kunitconfig for the same reason. See commit f84a9e965833
("clk: explicitly disable CONFIG_UML_PCI_OVER_VIRTIO in .kunitconfig"). The
commit itself declares itself to be a "short-term fix". But it is from 2022.
Maybe we can fix this properly at some point instead of papering over it.

> Dump as below:
> WARNING: CPU: 0 PID: 227 at lib/logic_iomem.c:141 __raw_readl+0xac/0xe0
> CPU: 0 UID: 0 PID: 227 Comm: kunit_try_catch Tainted: G
> Tainted: [N]=TEST
> Stack:
>  a0883d00 00000001 00000000 ffffff00
>  603ef142 60044832 6002598b 00000000
>  00000000 600211b3 00000001 00000000
> Call Trace:
>  [<6032534c>] ? __raw_readl+0xac/0xe0
>  [<60044832>] ? dump_stack_lvl+0x57/0x73
>  [<6002598b>] ? _printk+0x0/0x61
>  [<600211b3>] ? __warn.cold+0x61/0xeb
>  [<600212cc>] ? warn_slowpath_fmt+0x8f/0x9c
>  [<6002123d>] ? warn_slowpath_fmt+0x0/0x9c
>  [<6032534c>] ? __raw_readl+0xac/0xe0
>  [<6002123d>] ? warn_slowpath_fmt+0x0/0x9c
>  [<6029e2ad>] ? clk_gate_endisable+0xcd/0x110
>  [<6029e315>] ? clk_gate_enable+0x15/0x20
>  [<6028795e>] ? clk_core_enable+0x6e/0xf0
>  [<60289f1f>] ? clk_enable+0x4f/0xa0
>  [<602a06af>] ? clk_gate_test_enable+0xbf/0x360
>  [<60053df9>] ? os_nsecs+0x29/0x40
>  [<600cd300>] ? ktime_get_ts64+0x0/0x130
>  [<600816c0>] ? to_kthread+0x0/0x50
>  [<602507bb>] ? kunit_try_run_case+0x7b/0x100
>  [<600816c0>] ? to_kthread+0x0/0x50
>  [<60252aa0>] ? kunit_generic_run_threadfn_adapter+0x0/0x30
>  [<60252ab2>] ? kunit_generic_run_threadfn_adapter+0x12/0x30
>  [<60082091>] ? kthread+0xf1/0x270
>  [<60047591>] ? new_thread_handler+0x41/0x60
> ---[ end trace 0000000000000000 ]---
> 
> Fixes: 031cdd3bc3f3 ("kunit: Enable PCI on UML without triggering WARN()")
> Signed-off-by: Peng Fan <peng.fan@....com>

Reviewed-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>

> ---
>  drivers/clk/.kunitconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/.kunitconfig b/drivers/clk/.kunitconfig
> index 08e26137f3d9..4697bf9fb949 100644
> --- a/drivers/clk/.kunitconfig
> +++ b/drivers/clk/.kunitconfig
> @@ -1,4 +1,5 @@
>  CONFIG_KUNIT=y
> +CONFIG_KUNIT_UML_PCI=n
>  CONFIG_OF=y
>  CONFIG_OF_OVERLAY=y
>  CONFIG_COMMON_CLK=y

Maybe drop CONFIG_UML_PCI_OVER_VIRTIO=n from the same file?

Thomas