linux-kernel - Re: [PATCH v2 04/12] block: prohibit calls to bio_chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANubcdW7FxbtSRzePgO4wQwUFBpgbSYdL-GR87vUXKq7tAPsJg@mail.gmail.com>
Date: Sat, 29 Nov 2025 09:50:10 +0800
From: Stephen Zhang <starzhangzsd@...il.com>
To: Andreas Gruenbacher <agruenba@...hat.com>
Cc: Johannes.Thumshirn@....com, hch@...radead.org, gruenba@...hat.com, 
	ming.lei@...hat.com, linux-block@...r.kernel.org, 
	linux-bcache@...r.kernel.org, nvdimm@...ts.linux.dev, 
	virtualization@...ts.linux.dev, linux-nvme@...ts.infradead.org, 
	gfs2@...ts.linux.dev, ntfs3@...ts.linux.dev, linux-xfs@...r.kernel.org, 
	linux-kernel@...r.kernel.org, zhangshida@...inos.cn, 
	Gao Xiang <hsiangkao@...ux.alibaba.com>
Subject: Re: [PATCH v2 04/12] block: prohibit calls to bio_chain_endio

Andreas Gruenbacher <agruenba@...hat.com> 于2025年11月28日周五 20:58写道：
>
> On Fri, Nov 28, 2025 at 9:33 AM zhangshida <starzhangzsd@...il.com> wrote:
> > From: Shida Zhang <zhangshida@...inos.cn>
> >
> > Now that all potential callers of bio_chain_endio have been
> > eliminated, completely prohibit any future calls to this function.
> >
> > Suggested-by: Ming Lei <ming.lei@...hat.com>
> > Suggested-by: Andreas Gruenbacher <agruenba@...hat.com>
> > Suggested-by: Christoph Hellwig <hch@...radead.org>
> > Signed-off-by: Shida Zhang <zhangshida@...inos.cn>
> > ---
> >  block/bio.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/block/bio.c b/block/bio.c
> > index aa43435c15f..2473a2c0d2f 100644
> > --- a/block/bio.c
> > +++ b/block/bio.c
> > @@ -323,8 +323,13 @@ static struct bio *__bio_chain_endio(struct bio *bio)
> >         return parent;
> >  }
> >
> > +/**
> > + * This function should only be used as a flag and must never be called.
> > + * If execution reaches here, it indicates a serious programming error.
> > + */
> >  static void bio_chain_endio(struct bio *bio)
> >  {
> > +       BUG_ON(1);
>
> The below call is dead code and should be removed. With that, nothing
> remains of the first patch in this queue ("block: fix incorrect logic
> in bio_chain_endio") and that patch can be dropped.

Yeah, that makes it much clearer. I will do that.

Thanks,
Shida

>
> >         bio_endio(bio);
> >  }
> >
> > --
> > 2.34.1
> >
>
> Thanks,
> Andreas
>