linux-kernel - Re: [PATCH] clk: samsung: exynos-clkout: Assign .num before accessing .hws

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <176453127378.11952.4906451561257794028@lazor>
Date: Sun, 30 Nov 2025 11:34:33 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Alim Akhtar <alim.akhtar@...sung.com>, Chanwoo Choi <cw00.choi@...sung.com>, Gustavo A. R. Silva <gustavoars@...nel.org>, Kees Cook <kees@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>, Michael Turquette <mturquette@...libre.com>, Nathan Chancellor <nathan@...nel.org>, Sylwester Nawrocki <s.nawrocki@...sung.com>
Cc: Salvatore Bonaccorso <carnil@...ian.org>, linux-samsung-soc@...r.kernel.org, linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, stable@...r.kernel.org, Jochen Sprickerhof <jochen@...ickerhof.de>, Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH] clk: samsung: exynos-clkout: Assign .num before accessing .hws

Quoting Nathan Chancellor (2025-11-24 11:11:06)
> Commit f316cdff8d67 ("clk: Annotate struct clk_hw_onecell_data with
> __counted_by") annotated the hws member of 'struct clk_hw_onecell_data'
> with __counted_by, which informs the bounds sanitizer (UBSAN_BOUNDS)
> about the number of elements in .hws[], so that it can warn when .hws[]
> is accessed out of bounds. As noted in that change, the __counted_by
> member must be initialized with the number of elements before the first
> array access happens, otherwise there will be a warning from each access
> prior to the initialization because the number of elements is zero. This
> occurs in exynos_clkout_probe() due to .num being assigned after .hws[]
> has been accessed:
> 
>   UBSAN: array-index-out-of-bounds in drivers/clk/samsung/clk-exynos-clkout.c:178:18
>   index 0 is out of range for type 'clk_hw *[*]'
> 
> Move the .num initialization to before the first access of .hws[],
> clearing up the warning.
> 
> Cc: stable@...r.kernel.org
> Fixes: f316cdff8d67 ("clk: Annotate struct clk_hw_onecell_data with __counted_by")
> Reported-by: Jochen Sprickerhof <jochen@...ickerhof.de>
> Closes: https://lore.kernel.org/aSIYDN5eyKFKoXKL@eldamar.lan/
> Tested-by: Jochen Sprickerhof <jochen@...ickerhof.de>
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>
> ---

Applied to clk-next