linux-kernel - Re: [PATCH] clk: samsung: exynos-clkout: Assign .num before accessing .hws

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bbe07dc1-f77d-4dbd-9cd2-5efe8464f43b@kernel.org>
Date: Mon, 24 Nov 2025 21:55:00 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nathan Chancellor <nathan@...nel.org>,
 Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Chanwoo Choi <cw00.choi@...sung.com>, Alim Akhtar <alim.akhtar@...sung.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Kees Cook <kees@...nel.org>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: Salvatore Bonaccorso <carnil@...ian.org>,
 linux-samsung-soc@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org, stable@...r.kernel.org,
 Jochen Sprickerhof <jochen@...ickerhof.de>
Subject: Re: [PATCH] clk: samsung: exynos-clkout: Assign .num before accessing
 .hws

On 24/11/2025 20:11, Nathan Chancellor wrote:
> Commit f316cdff8d67 ("clk: Annotate struct clk_hw_onecell_data with
> __counted_by") annotated the hws member of 'struct clk_hw_onecell_data'
> with __counted_by, which informs the bounds sanitizer (UBSAN_BOUNDS)
> about the number of elements in .hws[], so that it can warn when .hws[]
> is accessed out of bounds. As noted in that change, the __counted_by
> member must be initialized with the number of elements before the first
> array access happens, otherwise there will be a warning from each access
> prior to the initialization because the number of elements is zero. This
> occurs in exynos_clkout_probe() due to .num being assigned after .hws[]
> has been accessed:
> 
>   UBSAN: array-index-out-of-bounds in drivers/clk/samsung/clk-exynos-clkout.c:178:18
>   index 0 is out of range for type 'clk_hw *[*]'
> 
> Move the .num initialization to before the first access of .hws[],
> clearing up the warning.
> 
> Cc: stable@...r.kernel.org
> Fixes: f316cdff8d67 ("clk: Annotate struct clk_hw_onecell_data with __counted_by")
> Reported-by: Jochen Sprickerhof <jochen@...ickerhof.de>
> Closes: https://lore.kernel.org/aSIYDN5eyKFKoXKL@eldamar.lan/
> Tested-by: Jochen Sprickerhof <jochen@...ickerhof.de>
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>

@Stephen,

Can you take this directly? You already pulled from me for next cycle,
so that way might be easier.

The fixed commit is from 2023, so does not really fit criteria for late
RC fixes, thus I propose for next release.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

Best regards,
Krzysztof