linux-kernel - Re: [PATCH v1 03/17] perf symbol-elf: Add missing puts on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aS3YpyPwlBq2ald2@x1>
Date: Mon, 1 Dec 2025 15:04:23 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	James Clark <james.clark@...aro.org>,
	Collin Funk <collin.funk1@...il.com>,
	Dmitry Vyukov <dvyukov@...gle.com>, Andi Kleen <ak@...ux.intel.com>,
	Thomas Falcon <thomas.falcon@...el.com>, Leo Yan <leo.yan@....com>,
	Yicong Yang <yangyicong@...ilicon.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Masami Hiramatsu (Google)" <mhiramat@...nel.org>,
	Stephen Brennan <stephen.s.brennan@...cle.com>,
	Haibo Xu <haibo1.xu@...el.com>, linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v1 03/17] perf symbol-elf: Add missing puts on error path

On Sat, Nov 22, 2025 at 12:19:15AM -0800, Ian Rogers wrote:
> In dso__process_kernel_symbol if inserting a map fails, probably
> ENOMEM, then the reference count puts were missing on the dso and map.

Reviewed-by: Arnaldo Carvalho de Melo <acme@...hat.com>

- Arnaldo
 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/util/symbol-elf.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
> index 9e820599bab3..4c76e680b13d 100644
> --- a/tools/perf/util/symbol-elf.c
> +++ b/tools/perf/util/symbol-elf.c
> @@ -1446,8 +1446,11 @@ static int dso__process_kernel_symbol(struct dso *dso, struct map *map,
>  			map__set_mapping_type(curr_map, MAPPING_TYPE__IDENTITY);
>  		}
>  		dso__set_symtab_type(curr_dso, dso__symtab_type(dso));
> -		if (maps__insert(kmaps, curr_map))
> +		if (maps__insert(kmaps, curr_map)) {
> +			dso__put(curr_dso);
> +			map__put(curr_map);
>  			return -1;
> +		}
>  		dsos__add(&maps__machine(kmaps)->dsos, curr_dso);
>  		dso__set_loaded(curr_dso);
>  		dso__put(*curr_dsop);
> -- 
> 2.52.0.rc2.455.g230fcf2819-goog