linux-kernel - Re: [PATCH v2 0/1] mcb: Add modpost support for processing MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aS3YvQMhbmnYiZrm@smile.fi.intel.com>
Date: Mon, 1 Dec 2025 20:04:45 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
Cc: andy@...nel.org, krzk@...nel.org, linus.walleij@...aro.org,
	nathan@...nel.org, nsc@...nel.org, gregkh@...uxfoundation.org,
	bleung@...omium.org, heikki.krogerus@...ux.intel.com,
	abhishekpandit@...omium.org, masahiroy@...nel.org,
	legion@...nel.org, hughd@...gle.com, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/1] mcb: Add modpost support for processing
 MODULE_DEVICE_TABLE

On Mon, Dec 01, 2025 at 05:07:19PM +0100, Jose Javier Rodriguez Barbarin wrote:
> During the process of update of one of the device drivers that are part of
> mcb bus (gpio-menz127.c), Krzysztof from GPIO subsystem asked me
> why I was adding new MODULE_ALIAS when I also added the same new
> information on MODULE_DEVICE_TABLE.
> 
> You can find the messages here:
> 
> https://lore.kernel.org/linux-gpio/80a20b13-7c6a-4483-9741-568424f957ef@kernel.org/
> 
> After a deeper analysis, I came across that the mcb_table_id defined inside
> MODULE_DEVICE_TABLE on all device drivers was being ignored as modpost was
> not processing the mcb MODULE_DEVICE_TABLE entries. For this reason, former
> contributors were using MODULE_ALIAS for enabling mcb to autoload the
> device drivers.
> 
> My proposal with these changes is to complete the mcb bus by adding
> modpost support for processing mcb MODULE_DEVICE_TABLE.
> 
> Once this patch is merged, I will send patches one by one for removing
> MODULE_ALIAS from all device drivers as they are no longer needed
> (as Andy Shevchenko suggested in v1 review).

Not sure if we need a cover letter for a single change, but yes, this
what I think the best approach and code wise it's fine to me:

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>

(but we still need a Fixes tag I assume).

-- 
With Best Regards,
Andy Shevchenko