linux-kernel - Re: [PATCH 2/2] fortify: Cleanup temp file also on non-successful exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46de5cc0-ed26-4fc9-8ae6-2e418a87c862@aosc.io>
Date: Mon, 1 Dec 2025 09:56:20 +0800
From: WangYuli <wangyuli@...c.io>
To: Nicolas Schier <nsc@...nel.org>, Kees Cook <kees@...nel.org>
Cc: WangYuli <wangyl5933@...naunicom.cn>,
 Nathan Chancellor <nathan@...nel.org>, linux-hardening@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
 Nicolas Schier <nicolas.schier@...ux.dev>
Subject: Re: [PATCH 2/2] fortify: Cleanup temp file also on non-successful
 exit

On 2025/11/29 03:27, Nicolas Schier wrote:

> From: Nicolas Schier <nicolas.schier@...ux.dev>
>
> Ensure cleanup of test_fortify.sh's temporary file also on script
> interruption, or some common signals.
>
> Reported-by: WangYuli <wangyuli@...c.io>
> Closes: https://lore.kernel.org/linux-kbuild/20251112114725.287349-1-wangyuli@aosc.io/
> Signed-off-by: Nicolas Schier <n.schier@....de>
> ---
>   lib/test_fortify/test_fortify.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/test_fortify/test_fortify.sh b/lib/test_fortify/test_fortify.sh
> index 368d07d9acbf..ad6dd44fa31c 100644
> --- a/lib/test_fortify/test_fortify.sh
> +++ b/lib/test_fortify/test_fortify.sh
> @@ -29,7 +29,7 @@ shift
>   __cleanup() {
>   	rm -f "$TMP"
>   }
> -trap __cleanup EXIT
> +trap __cleanup EXIT HUP INT QUIT TERM
>   
>   # Function names in warnings are wrapped in backticks under UTF-8 locales.
>   # Run the commands with LANG=C so that grep output will not change.
>

Reviewed-by: WangYuli <wangyuli@...c.io>

Thans,

--

WangYuli