linux-kernel - Re: [PATCH 1/2] fortify: Rename temporary file to match ignore pattern

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251201234105.GB2018462@ax162>
Date: Mon, 1 Dec 2025 16:41:05 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Nicolas Schier <nsc@...nel.org>
Cc: Kees Cook <kees@...nel.org>, WangYuli <wangyuli@...c.io>,
	WangYuli <wangyl5933@...naunicom.cn>,
	linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kbuild@...r.kernel.org,
	Nicolas Schier <nicolas.schier@...ux.dev>
Subject: Re: [PATCH 1/2] fortify: Rename temporary file to match ignore
 pattern

On Fri, Nov 28, 2025 at 08:27:57PM +0100, Nicolas Schier wrote:
> From: Nicolas Schier <nicolas.schier@...ux.dev>
> 
> test_fortify.sh uses a temporary file that might appear as untracked
> file in some rare sitations.  Rename it to match one of top-level's
> gitignore patterns.
> 
> Reported-by: WangYuli <wangyuli@...c.io>
> Closes: https://lore.kernel.org/linux-kbuild/20251112114725.287349-1-wangyuli@aosc.io/
> Signed-off-by: Nicolas Schier <n.schier@....de>

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

Not a big problem but some tools might complain about the email mismatch
between the From: line (which will end up being the author) and the
Signed-off-by line.

> ---
>  lib/test_fortify/test_fortify.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/test_fortify/test_fortify.sh b/lib/test_fortify/test_fortify.sh
> index c2688ab8281d..368d07d9acbf 100644
> --- a/lib/test_fortify/test_fortify.sh
> +++ b/lib/test_fortify/test_fortify.sh
> @@ -17,7 +17,7 @@ WANT="__${FILE%%-*}"
>  # Argument 2: Where to write the build log.
>  OUT="$1"
>  shift
> -TMP="${OUT}.tmp"
> +TMP="${OUT%/*}/.${OUT##*/}.tmp"
>  
>  # Argument 3: Path to "nm" tool.
>  NM="$1"
> 
> -- 
> 2.51.0
>