linux-kernel - Re: [PATCH 1/2] android: binderfs: add missing parameters in binder_ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aS8dO9V4suAPF4QG@google.com>
Date: Tue, 2 Dec 2025 17:09:15 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: Sunday Adelodun <adelodunolaoluwa@...oo.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arve <arve@...roid.com>, Todd Kjos <tkjos@...roid.com>,
	Martijn Coenen <maco@...roid.com>,
	Joel Fernandes <joelagnelf@...dia.com>,
	Christian Brauner <brauner@...nel.org>,
	Suren Baghdasaryan <surenb@...gle.com>,
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
	david.hunter.linux@...il.com,
	linux-kernel-mentees@...ts.linuxfoundation.org,
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 1/2] android: binderfs: add missing parameters in
 binder_ctl_ioctl()'s doc

On Fri, Nov 21, 2025 at 12:12:02PM +0100, Sunday Adelodun wrote:
> The kernel-doc comment for binder_ctl_ioctl() lacks descriptions for the
> @file, @cmd, and @arg parameters, which triggers warnings during
> documentation builds.

Could you please add the warnings here?

> 
> Add the missing parameter descriptions to keep the
> kernel-doc consistent and free of warnings.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202511201725.ni2HZ2PP-lkp@intel.com/

The link for the `Closes:` tag should be on the same line.

> Signed-off-by: Sunday Adelodun <adelodunolaoluwa@...oo.com>
> ---
>  drivers/android/binderfs.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> index be8e64eb39ec..47f6d1e5971e 100644
> --- a/drivers/android/binderfs.c
> +++ b/drivers/android/binderfs.c
> @@ -224,6 +224,9 @@ static int binderfs_binder_device_create(struct inode *ref_inode,
>  
>  /**
>   * binder_ctl_ioctl - handle binder device node allocation requests
> + * @file: The file pointer for the binder-control device node.
> + * @cmd: The ioctl command.
> + * @arg: The ioctl argument.

Can you please follow other kernel-doc format in the file? e.g.
alignment, no period at the end, etc.

>   *
>   * The request handler for the binder-control device. All requests operate on
>   * the binderfs mount the binder-control device resides in:
> -- 
> 2.43.0
> 

This is the wrong file though. The reported issue was for the
drivers/android/binder/rust_binderfs.c file. Can you add the same
kernel-doc additions to both files in your next version?

Thanks,
Carlos Llamas