linux-kernel - Re: [PATCH 2/2] android: binder: add missing return value documentation for binder_apply_fd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aS8dzB6-CGfitagu@google.com>
Date: Tue, 2 Dec 2025 17:11:40 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: Sunday Adelodun <adelodunolaoluwa@...oo.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arve <arve@...roid.com>, Todd Kjos <tkjos@...roid.com>,
	Martijn Coenen <maco@...roid.com>,
	Joel Fernandes <joelagnelf@...dia.com>,
	Christian Brauner <brauner@...nel.org>,
	Suren Baghdasaryan <surenb@...gle.com>,
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
	david.hunter.linux@...il.com,
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH 2/2] android: binder: add missing return value
 documentation for binder_apply_fd_fixups()

On Fri, Nov 21, 2025 at 12:12:03PM +0100, Sunday Adelodun wrote:
> The kernel-doc for binder_apply_fd_fixups() was missing a description of
> its return value, which triggers a kernel-doc warning.

How does one trigger this warning? Was there a report of this? Can you
add the warning you see to the commit message?

> 
> Add the missing "Return:" entry to doc that the function returns 0 on
> success or a negative errno on failure.
> 
> Signed-off-by: Sunday Adelodun <adelodunolaoluwa@...oo.com>
> ---
>  drivers/android/binder.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index a3a1b5c33ba3..535fc881c8da 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -4669,6 +4669,8 @@ static int binder_wait_for_work(struct binder_thread *thread,
>   *
>   * If we fail to allocate an fd, skip the install and release
>   * any fds that have already been allocated.
> + *
> + * Return: 0 on success, a negative errno code on failure.
>   */
>  static int binder_apply_fd_fixups(struct binder_proc *proc,
>  				  struct binder_transaction *t)
> -- 
> 2.43.0
>

Thanks,
Carlos Llamas