linux-kernel - Re: [PATCH 2/5] perf tools: Fix split kallsyms DSO counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fWPCtER+BR5BFX4XjBCijTpB+kAkaSe+0pZ8fAx_72NHg@mail.gmail.com>
Date: Tue, 2 Dec 2025 12:56:18 -0800
From: Ian Rogers <irogers@...gle.com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>, James Clark <james.clark@...aro.org>, 
	Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...nel.org>, 
	LKML <linux-kernel@...r.kernel.org>, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 2/5] perf tools: Fix split kallsyms DSO counting

On Tue, Dec 2, 2025 at 12:16 AM Namhyung Kim <namhyung@...nel.org> wrote:
>
> It's counted twice as it's increased after calling maps__insert().  I
> guess we want to increase it only after it's added properly.
>
> Fixes: 2e538c4a1847291cf ("perf tools: Improve kernel/modules symbol lookup")
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/util/symbol.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index 5a38435d90c96092..8eea49c50453d13a 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -960,11 +960,11 @@ static int maps__split_kallsyms(struct maps *kmaps, struct dso *dso, u64 delta,
>                         if (dso__kernel(dso) == DSO_SPACE__KERNEL_GUEST)
>                                 snprintf(dso_name, sizeof(dso_name),
>                                         "[guest.kernel].%d",
> -                                       kernel_range++);
> +                                       kernel_range);
>                         else
>                                 snprintf(dso_name, sizeof(dso_name),
>                                         "[kernel].%d",
> -                                       kernel_range++);
> +                                       kernel_range);
>
>                         ndso = dso__new(dso_name);
>                         map__zput(curr_map);
> --
> 2.52.0.158.g65b55ccf14-goog
>