linux-kernel - Re: [PATCH 1/5] perf tools: Mark split kallsyms DSOs as loaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fX_Qxmi5WNS5Xd++zJbvoM2kPn0cF-FfVWsUUTvov86Ng@mail.gmail.com>
Date: Tue, 2 Dec 2025 12:57:45 -0800
From: Ian Rogers <irogers@...gle.com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>, James Clark <james.clark@...aro.org>, 
	Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...nel.org>, 
	LKML <linux-kernel@...r.kernel.org>, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/5] perf tools: Mark split kallsyms DSOs as loaded

On Tue, Dec 2, 2025 at 12:16 AM Namhyung Kim <namhyung@...nel.org> wrote:
>
> The maps__split_kallsyms() will split symbols to module DSOs if it comes
> from a module.  It also handled some unusual kernel symbols after modules
> by creating new kernel maps like "[kernel].0".
>
> But they are pseudo DSOs to have those unexpected symbols.  They should
> not be considered as unloaded kernel DSOs.  Otherwise the dso__load()
> for them will end up calling dso__load_kallsyms() and then
> maps__split_kallsyms() again and again.
>
> Fixes: 2e538c4a1847291cf ("perf tools: Improve kernel/modules symbol lookup")

Fixed after 16 years :-)

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/util/symbol.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index d8fc5ea77f849326..5a38435d90c96092 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -972,6 +972,7 @@ static int maps__split_kallsyms(struct maps *kmaps, struct dso *dso, u64 delta,
>                                 return -1;
>
>                         dso__set_kernel(ndso, dso__kernel(dso));
> +                       dso__set_loaded(ndso);
>
>                         curr_map = map__new2(pos->start, ndso);
>                         if (curr_map == NULL) {
> --
> 2.52.0.158.g65b55ccf14-goog
>